fix(platform): display env vars/secrets and passkeys as compact headerless tables (#1950)#2114
Open
larryro wants to merge 1 commit into
Open
fix(platform): display env vars/secrets and passkeys as compact headerless tables (#1950)#2114larryro wants to merge 1 commit into
larryro wants to merge 1 commit into
Conversation
Collaborator
Author
Desk review — #1950 (headerless tables for env vars/secrets & passkeys)Verdict: READY TO MERGE. Clean, focused change that meets all three acceptance criteria on both surfaces. Reviewed in two rounds (breadth across correctness/robustness/elegance/tests/boundaries, then independent re-verification of every candidate blocker). Verification performed
What's good
Non-blocking notes (optional follow-ups, do not block merge)
None of the above gates the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1950. Both env vars/secrets (the shared
EnvVarListEditor, used by the agent/workflow env editors) and the account passkeys list now render as compact headerless tables following one shared minimal convention:DeleteDialog).Changes
app/components/env/env-var-list-editor.tsx— rows moved into@tale/ui/table(Table/TableBody/TableRow/TableCell); removed theSkeletonTextloading state and the empty-state text; the table renders only whenlocalRows.length > 0. The per-row trash button now opens aDeleteDialog; a brand-new blank row is dropped immediately (no data to confirm).app/features/settings/account/components/passkey-section.tsx— card list replaced with a headerless table; empty-state text removed; the ghost "Remove" text button is now a trash icon button gated byDeleteDialog.messages/{en,de,fr}.json— removed the now-deadenvEditor.none/twoFactor.passkeys.emptykeys; addedenvEditor.confirmRemove{Title,Description}andtwoFactor.passkeys.confirmRevoke{Title,Description}in all three base locales.Verification
bunx tsc --noEmit(platform) — clean.oxlint --type-awareon both changed files — 0 warnings, 0 errors.oxfmt --checkon changed files + locale JSON — clean.